BREAKING: Make single wallet config more explicit #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
ianco
approved these changes
Jul 17, 2024
|
|
NB: renaming |
|
Yes, it should. I thought it had been listed. It is a critical change for multitenant single wallet deployments. @swcurran |
|
OK - thanks. Will add in the next release. |
swcurran
changed the title
darshilnb
pushed a commit
to Northern-Block/aries-cloudagent-python
that referenced
this pull request
Sep 5, 2024
* Make single wallet config more explicit Signed-off-by: jamshale <[email protected]> * Fix minor string tuple issue Signed-off-by: jamshale <[email protected]> --------- Signed-off-by: jamshale <[email protected]> Co-authored-by: Ian Costanzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes some naming and configuration to make the multitenant single wallet vs multi wallet settings and usage more clear. Askar wallets can use either the basic manager
MultitenantManagerwhich is used by default and creates a DB/wallet for each tenant. Or, it can use theAskarProfileMultitenantManagerto create subwallets in a single DB/wallet. This has been renamed toSingleWalletAskarMultitenantManagerfor clarity, and the config changed tomultitenancy-config: '{"wallet_type": "single-wallet-askar"}'frommultitenancy-config: '{"wallet_type": "askar-profile"}'Also fixed an issue with the upgrade check during startup that was using the base manager before initialization and creating subwallet db's on restart when in single wallet mode. I'm looking into this more because the
BaseMultitenantManageris injected in many other places. Need to make sure they are also using the correct manager via theMultitenantManagerProvider.Added some documentation in
Multitenancy.mdNote: the multitenant_provider plugin needs to be update because it inherits this class. Already done in my forked repo.