Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 improve record querying logic #3083

Merged
merged 2 commits into from
Jul 4, 2024
Merged

🎨 improve record querying logic #3083

merged 2 commits into from
Jul 4, 2024

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented Jul 4, 2024

Minor amendments that I wanted to include before #3082 was merged.

Expands error handling for the unlikely case where json.loads fails, and improves readability / reduces complexity of nested if conditions.

@ff137 ff137 mentioned this pull request Jul 4, 2024
Merged
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jamshale
jamshale approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Much more readable

@jamshale jamshale merged commit 314062b into openwallet-foundation:main Jul 4, 2024
8 checks passed
@ff137 ff137 deleted the art/improve-record-query branch July 4, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamshale jamshale jamshale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ff137 @jamshale