🐛 fix storage record pagination with post-filter query params #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Signed-off-by: ff137 <[email protected]>
…ost_filter Signed-off-by: ff137 <[email protected]>
ff137
force-pushed
the
fix/paginated-queries-with-post-filter
branch
from
3ebce10 to
d824998
Compare
jamshale
approved these changes
Jul 4, 2024
|
|
Oof, I was just about to commit a change to make it more readable 😅 I agree some parts were a bit overly complex |
ff137
added a commit
to ff137/acapy
that referenced
this pull request
Jul 4, 2024
…llet-foundation#3082) * 🐛 fix storage record pagination with post-filter query params Signed-off-by: ff137 <[email protected]> * ✅ add test coverage for querying storage record with pagination and post_filter Signed-off-by: ff137 <[email protected]> --------- Signed-off-by: ff137 <[email protected]> Co-authored-by: jamshale <[email protected]>
|
No prob, I'll make another PR with some minor amendments, also improving the error handling which is prob worth it |
|
Ok. Sorry about that. Another PR will be good. |
|
All good, I was slow 😄 included the changes in #3083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3001 (comment)
Marking as draft to first validate things work as expected (testing here: didx-xyz/aries-cloudapi-python#850)