Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from black to ruff #3080

Merged

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Jul 3, 2024

Completely removes black from the project in favour of ruff for linting and formatting.

Adjust the decontainer and the github actions workflow.

@jamshale jamshale marked this pull request as ready for review July 3, 2024 21:02
@jamshale jamshale force-pushed the switch-from-black-to-ruff branch from 12b43e1 to 0b41ebd Compare July 3, 2024 22:44
@jamshale
Copy link
Contributor Author

jamshale commented Jul 4, 2024

Also, I forgot to mention that the ruff linting based on the rules in pyproject.toml weren't actually being checked by the github action pipelines. This fixes that issues now and makes sure all linting and formatting is successful when opening a PR.

@jamshale jamshale enabled auto-merge (squash) July 4, 2024 21:44
@jamshale jamshale merged commit 39f2b4f into openwallet-foundation:main Jul 4, 2024
7 checks passed
Copy link

sonarqubecloud bot commented Jul 4, 2024

ff137 pushed a commit to ff137/acapy that referenced this pull request Jul 4, 2024
* Remove black in favor of ruff

Signed-off-by: jamshale <[email protected]>

* Update poetry.lock file

Signed-off-by: jamshale <[email protected]>

* Remove only changed files from format check for now

Signed-off-by: jamshale <[email protected]>

* Fix poetry.lock file after rebase

Signed-off-by: jamshale <[email protected]>

* Use sude and fix format individual file

Signed-off-by: jamshale <[email protected]>

---------

Signed-off-by: jamshale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants