Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher queue improvements #287

Merged

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Nov 29, 2019

  • Add environment variable for adjusting maximum active dispatcher tasks
  • Track dispatcher timing via its task queue and log time spent in queue
  • Fix issue with empty TaskQueue evaluating as false

@codecov-io
Copy link

codecov-io commented Nov 29, 2019

Codecov Report

Merging #287 into master will increase coverage by 0.01%.
The diff coverage is 89.55%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   86.25%   86.26%   +0.01%     
==========================================
  Files         232      232              
  Lines       10781    10862      +81     
==========================================
+ Hits         9299     9370      +71     
- Misses       1482     1492      +10

@andrewwhitehead andrewwhitehead changed the title Add environment variable for adjusting maximum active dispatcher tasks Dispatcher queue improvements Nov 30, 2019
WadeBarnes added a commit to bcgov/aries-cloudagent-container that referenced this pull request Dec 3, 2019
@WadeBarnes
Copy link
Contributor

I'm still running performance (scaling) test on this, but it's been stable and has resolved the issues I reported regarding agents getting into a bad state; #280

@andrewwhitehead andrewwhitehead force-pushed the feature/dispatch-active branch from 3ce83b2 to 65ee313 Compare December 9, 2019 19:03
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wade has been running this in prod.

@swcurran swcurran merged commit 0a9788c into openwallet-foundation:master Dec 10, 2019
@andrewwhitehead andrewwhitehead deleted the feature/dispatch-active branch February 29, 2020 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants