Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to run_demo script to support Apple M1 CPUs #2843

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Update to run_demo script to support Apple M1 CPUs #2843

merged 4 commits into from
Mar 20, 2024

Conversation

swcurran
Copy link
Contributor

Fixes #2842

@swcurran swcurran requested a review from WadeBarnes March 18, 2024 19:50
WadeBarnes
WadeBarnes previously approved these changes Mar 18, 2024
@jamshale
Copy link
Contributor

Integration test fail is this one where a cred def makes it to the ledger but fails to save it in the wallet :/ Seen it a few times. I'm going to create a ticket for it.

@jamshale
Copy link
Contributor

jamshale commented Mar 19, 2024

The last integration test had the fails where I added a 3 second retry in endorsement. Where it's trying to promote the did. Annoying. These were passing consistently for several days. It also had a fail for the cred def being on the ledger and not in the wallet.

I could add a few more retries, but seems like the ledger is getting hung up or something.

I need to look at the cred_def not in wallet error separately. No idea what's going on with that yet.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@swcurran swcurran merged commit 5501672 into openwallet-foundation:main Mar 20, 2024
8 checks passed
@swcurran swcurran deleted the m1-build-issue branch March 20, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors running ./run_demo faber on Apple M1
3 participants