Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publish-docs to operate on main and on branches prefixed with docs-v #2804

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Conversation

swcurran
Copy link
Contributor

Signed-off-by: Stephen Curran [email protected]

@swcurran swcurran requested a review from WadeBarnes February 21, 2024 18:54
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@swcurran
Copy link
Contributor Author

@WadeBarnes -- check it out. Should:

  • publish docs for any created branches or tags ("on", "create")
  • publish docs for pushes to branches that start with "docs-v" or main
  • if the pushed or created tag / branch is not "main" or has a "v-docs" prefix, exit happily.
  • otherwise, normal flow for mike (versioning support) and mkdocs

@WadeBarnes
Copy link
Contributor

Looks like it should work. Could add the - docs-v* filter to the on create?

@swcurran
Copy link
Contributor Author

I had just added the GHA extension to VS-Code when I did this. Turns out that create doesn’t support branches. I think early versions might have (found a reference on the internet that it did), but the extension flagged it as an error and when I checked the GHA docs, it doesn’t take any parameters.

@swcurran swcurran merged commit 3df1389 into openwallet-foundation:main Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants