-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump pyld version to 2.0.4 #2795
Bump pyld version to 2.0.4 #2795
Conversation
Signed-off-by: PatStLouis <[email protected]>
I’ll watch for the tests, and we’ll include this in the pending release candidate. |
A couple of the integration tests have been failing a lot today. I'm not sure why, as they had been passing consistently. Might be a resources and timing issue. I ran the failing test locally on main and it passed. Pretty sure we can ignore this fail if we want. |
From the available logs the step that failed seems due to a cred_def being on the ledger but not in the agent's wallet. Sounds like a false positive as in not related to this PR, do you have the ability to rerun the tests @jamshale ? We had occurrences before where the tests sometimes fail for some arbitrary reason, probably resource or timing issue like you mentioned. |
I triggered a re-run be updating the branch, lets see |
Add I merged another PR, so you are out of date again. Update and I will bypass the protections.., |
Quality Gate passedIssues Measures |
This is to address a bug we have found in the pyld library which was incorrectly asserting context elements as null.
Addresses issue #2743 and will close PR #2744.
For background information you can read this closed issue on the pyld repo.
@swcurran I tested these changes and was able to verify traceable credentials with the proper did document content.