Move emit events to profile and delay sending until after commit #2760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
|
jamshale
reviewed
Feb 7, 2024
| """ | ||
|
|
||
| # TODO check transaction, either queue or emit event | ||
| if force_emit or (not self.is_transaction): |
There was a problem hiding this comment.
Only problem I could see is events getting stuck in an is_transaction state. I'm not aware if that's possible or not.
There was a problem hiding this comment.
This should get cleared when the transaction is either committed or rolled back. (At least that's my expectation, I haven't traced every single path of code ...)
jamshale
approved these changes
Feb 7, 2024
dbluhm
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2000
This update doesn't break anything ... I haven't been able to duplicate the issue (by strategically inserting
sleep()statements) so I can't 100% confirm that this fixes the issue, but I think it "should" ...