fix: partial revert of ConnRecord schema change #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
force-pushed
the
fix/connrecord-schema-name
branch
2 times, most recently
from
d298439 to
aa351e9
Compare
dbluhm
force-pushed
the
fix/connrecord-schema-name
branch
from
aa351e9 to
5326a74
Compare
This uses the same schema name originally used to avoid issues downstream caused by the openapi name also changing from ConnRecord to StoredConnRecord. Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
dbluhm
force-pushed
the
fix/connrecord-schema-name
branch
from
5326a74 to
595a9b0
Compare
|
jamshale
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially reverts some of the changes made in #2661 relating to the
ConnRecordSchema. The changes in that PR caused the generated openapi to rename the definition toStoredConnRecord. We can get the same fix while not causing a change to the name in the openapi; this is preferable because otherwise it impacts downstream consumers of the openapi definition.