Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

did peer 4 resolution #2692

Merged

Conversation

Jsyro
Copy link
Contributor

@Jsyro Jsyro commented Jan 2, 2024

Signed-off-by: Jason Syrotuck <[email protected]>
@Jsyro Jsyro force-pushed the feature/did-peer-4-resolution branch from c2551ca to 0e279a2 Compare January 2, 2024 21:27
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Jsyro Jsyro requested review from dbluhm, swcurran and esune January 2, 2024 21:39
@swcurran
Copy link
Contributor

swcurran commented Jan 2, 2024

Looks good to me, but I defer to @dbluhm on this one. We’ll want an “emit” capability — that will be a follow up PR?

@Jsyro
Copy link
Contributor Author

Jsyro commented Jan 2, 2024

Looks good to me, but I defer to @dbluhm on this one. We’ll want an “emit” capability — that will be a follow up PR?

Yes, I planned to add 'emit' functionality in future work when prioritized, but this a change that adds functionality and can be tested !

Copy link
Member

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me, will leave the final review and approval/comments to @dbluhm

@dbluhm dbluhm merged commit 44655fa into openwallet-foundation:main Jan 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants