Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update broken demo dependency #2638

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

mrkaurelius
Copy link
Contributor

Couldn't proceed with further local testing on my host. Probably due to differences in python versions.

    self.proc = await asyncio.wait_for(future, 20, loop=loop)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: wait_for() got an unexpected keyword argument 'loop'

But pip install works fine now.

Signed-off-by: Abdulhamit Kumru <[email protected]>
@mrkaurelius
Copy link
Contributor Author

related to #2637

@dbluhm
Copy link
Contributor

dbluhm commented Nov 29, 2023

What version of Python are you running? Our current target is Python 3.9 but we also test nightly on 3.10. I believe that only hits the PR tests and not the integration tests and I'm not sure the demo reqs would get pulled into those integration tests anyways...

@dbluhm dbluhm enabled auto-merge November 29, 2023 14:57
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm merged commit 3111be4 into openwallet-foundation:main Nov 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants