🐛 fix wallet_update when only extra_settings
requested
#2612
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor bug fix:
wallet_update
has a condition:This ignores the newly added
extra_settings
, and so trying to update a wallet with onlyextra_settings
in the request raises a faulty Bad Request: "At least one parameter is required."This PR simply adds
extra_settings
to the list of possible parameters.Edit: I moved the default value of
extra_settings
to be set in theget_extra_settings_dict_per_tenant
call. Ifextra_settings
defaults to{}
immediately, then thev is None
check forextra_settings
is never True.