Issue 2570 devcontainer ruff, black and pytest #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Sherman <[email protected]>
Signed-off-by: Jason Sherman <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
usingtechnology
changed the title
dbluhm
approved these changes
Nov 8, 2023
|
@usingtechnology any way you could merge these changes into the anoncreds-rs branch? I did a quick check and there are a few conflicts. |
If that branch is stable today, I can take a crack at it. Probably not too far off... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2570
Adding
--ruffto thepytestconfiguration inpyproject.tomladversely affects thedevcontainer: the Testing view does not load properly (tests are discovered but not listed). It is convenient to have those tests loaded in the Testing view for debugging and troubleshooting, allowing the developer to isolate and repeatedly run individual files/tests quickly.One important caveat is the devcontainer creates its own
.pytest.inifile (it is gitgnored) which overrides the configuration in pyproject.toml.ruffwill ignore this file and continue to use the pyproject configuration. Theruffextension is also explicitly configured to use the pyproject configuration. Creating a.pytest.inifile when the container is built means that file will continue to exist on the file system outside of the container. So if a developer flips between using the devcontainer and running commands directly on their system they will pick up the.pytest.inifile which would not runruffcheck when callingpython -m pytest .on the local machine. These changes do NOT impact./scripts/run_testsor./scripts/run_tests_indy- those will continue to use the pyproject configuration.This PR adds extensions for
ruffandblack, setting upblackas the default formatted and integratingruffinto the editor/command palette.Updates have been made to the devcontainer README to inform users/developers of the changes and caveats.
NOTE - the
ruffversion has been updated to match the extension.