Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more doc corrections #2446

Merged
merged 2 commits into from
Aug 25, 2023

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Aug 24, 2023

Fixes #2445. ACA-Py's DIDDoc class performs transformations prior to storing. This PR accounts for these transformations better.

cc @WadeBarnes @nodlesh

Signed-off-by: Daniel Bluhm <[email protected]>
swcurran
swcurran previously approved these changes Aug 24, 2023
@swcurran
Copy link
Contributor

@dbluhm — can you please look at the failing PR Tests Run? Let me know when ready to merge.

@Jsyro — can you take a quick look at this one, please? Note the “;” in the DIDDoc that we wondered about…it does exist in the wild — for no particular reason that I know of :-)

Jsyro
Jsyro previously approved these changes Aug 24, 2023
Copy link
Contributor

@Jsyro Jsyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appropriate transformations based on data and code i've seen.

Signed-off-by: Daniel Bluhm <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm dbluhm requested a review from swcurran August 24, 2023 23:19
@swcurran swcurran merged commit 303bd37 into openwallet-foundation:main Aug 25, 2023
@dbluhm dbluhm deleted the fix/doc-corrections branch January 30, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection Errors in Regression Testing with Bifold based wallet
3 participants