Extend --preserve-exchange-records to include Presentation Exchange.
#2352
Conversation
Add `auto_remove` flags to appropriate APIs for override of default behaviour. Signed-off-by: Jason Sherman <[email protected]>
| auto_remove = fields.Bool( | ||
| description=( | ||
| "Whether to remove the presentation exchange record on completion " | ||
| "(overrides --preserve-exchange-records configuration setting)" | ||
| ), | ||
| required=False, | ||
| default=False, | ||
| ) |
There was a problem hiding this comment.
This feels misplaced. Why is this on an indy specific model?
There was a problem hiding this comment.
maybe there is a bad/inappropriate inheritance structure...
but that schema is the request schema for /present-proof/records/{pres_ex_id}/send-presentation...
yeah, some ugly stuff going on there.
There was a problem hiding this comment.
great catch though. i don't want to get into a complete re-engineering here but will create a new schema using the IndyPresSpecSchema as a parent and add the auto_remove to the child. Should be a step in the right direction and put the auto_remove where it is actually used.
Signed-off-by: Jason Sherman <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
Add
auto_removeflags to appropriate APIs for override of default behaviour.Verifiers/Provers can override default behaviour in
send-request(both free presentation and bound presentation),send-presentation,send-proposal.Note: added
auto_removeto issue credentials (1 and 2)send-request, allowing holders to override the default behaviour.Closes #2126
Closes #2206