Feature: JWT Sign and Verify Admin Endpoints with DID Support #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
And fix issue with did:sov: from unqualified dids Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
…oudagent-python into feature/wallet-jwt
Signed-off-by: Adam Burdett <[email protected]>
Signed-off-by: Adam Burdett <[email protected]>
… into feature/wallet-jwt
|
To give an idea of how we're thinking these might be used, we've found this kind of endpoint to be really helpful for things like signing governance files and other documents that we want to be able to commit to with keys associated with our public DIDs, etc. An additional clarification: this does not include any changes to support issuing or presenting JWT credentials using ICv2 or PPv2; however, while simple, this does implement the basic crypto and JWT formatting steps. |
andrewwhitehead
approved these changes
Jul 12, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces two new endpoints to the admin wallet API:
POST /wallet/jwt/sign: This endpoint allows for the creation of a JWS (JSON Web Signature) by providing a DID (Decentralized Identifier) or verification method along with a header and payload. The JWS is generated using the associated keys linked to the provided DID.POST /wallet/jwt/verify: With this endpoint, you can verify a JWS by providing the JWS itself. The implementation includes a DID resolver, which leverages the JWS header to resolve a DID document. This document is then used to verify the signature of the provided JWS.These new endpoints expand the functionality of our admin wallet API, empowering users to perform signing and verification operations conveniently. I have tested the code and ensured its compatibility with our existing system.
Signed-off-by: Adam Burdett [email protected]
Co-authored-by: Daniel Bluhm [email protected]