Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split application configuration into separate modules and add tests #23

Merged
merged 21 commits into from
Jul 2, 2019

Conversation

andrewwhitehead
Copy link
Contributor

  • Move command line parsing into config/argparse
  • Move context initialization into config/default_context (add ContextBuilder class)
  • Move logging into config/logging
  • Add related unit tests, plus tests for conductor and dispatcher

@andrewwhitehead andrewwhitehead requested a review from nrempel June 28, 2019 20:59
nrempel
nrempel previously approved these changes Jun 28, 2019
nrempel
nrempel previously approved these changes Jun 28, 2019
@codecov
Copy link

codecov bot commented Jun 29, 2019

Codecov Report

Merging #23 into master will increase coverage by 1.44%.
The diff coverage is 73.8%.

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   66.64%   68.09%   +1.44%     
==========================================
  Files         173      176       +3     
  Lines        7216     7384     +168     
==========================================
+ Hits         4809     5028     +219     
+ Misses       2407     2356      -51

@ianco
Copy link
Contributor

ianco commented Jun 30, 2019

I get an error running the agent with the updates from this PR:

tob-agent_1 | 2019-06-30 14:38:38,033 aries_cloudagent.conductor ERROR Unable to start administration API
tob-agent_1 | Traceback (most recent call last):
tob-agent_1 | File "/home/indy/aries_cloudagent/admin/server.py", line 169, in make_application
tob-agent_1 | f"{protocol_module_path}.routes"
tob-agent_1 | File "/home/indy/aries_cloudagent/classloader.py", line 102, in load_module
tob-agent_1 | mod = import_module(mod_path)
tob-agent_1 | File "/home/indy/.pyenv/versions/3.6.8/lib/python3.6/importlib/init.py", line 126, in import_module
tob-agent_1 | return _bootstrap._gcd_import(name[level:], package, level)
tob-agent_1 | File "", line 994, in _gcd_import
tob-agent_1 | File "", line 971, in _find_and_load
tob-agent_1 | File "", line 955, in _find_and_load_unlocked
tob-agent_1 | File "", line 665, in _load_unlocked
tob-agent_1 | File "", line 678, in exec_module
tob-agent_1 | File "", line 219, in _call_with_frames_removed
tob-agent_1 | File "/home/indy/src/subdir/credential-registry/message_families/issuer_registration/indy_catalyst_issuer_registration/routes.py", line 13, in
tob-agent_1 | from .manager import IssuerRegistrationManager
tob-agent_1 | File "/home/indy/src/subdir/credential-registry/message_families/issuer_registration/indy_catalyst_issuer_registration/manager.py", line 8, in
tob-agent_1 | from aries_cloudagent.messaging.util import send_webhook
tob-agent_1 | ImportError: cannot import name 'send_webhook'
tob-agent_1 |
tob-agent_1 | During handling of the above exception, another exception occurred:
tob-agent_1 |
tob-agent_1 | Traceback (most recent call last):
tob-agent_1 | File "/home/indy/aries_cloudagent/conductor.py", line 184, in start
tob-agent_1 | await self.admin_server.start()
tob-agent_1 | File "/home/indy/aries_cloudagent/admin/server.py", line 211, in start
tob-agent_1 | self.app = await self.make_application()
tob-agent_1 | File "/home/indy/aries_cloudagent/admin/server.py", line 173, in make_application
tob-agent_1 | self.logger.error(
tob-agent_1 | AttributeError: 'AdminServer' object has no attribute 'logger'

…hanges to transports and admin server

Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
Signed-off-by: Andrew Whitehead <[email protected]>
@ianco ianco merged commit 80f27bf into openwallet-foundation:master Jul 2, 2019
dbluhm added a commit to dbluhm/aries-cloudagent-python that referenced this pull request Oct 16, 2019
…fix_invite_handling

invite listing types
@andrewwhitehead andrewwhitehead deleted the config-split branch February 29, 2020 21:45
dbluhm pushed a commit that referenced this pull request Oct 2, 2020
Merging with the up-to-date version of ACA-Py
dbluhm added a commit to dbluhm/aries-cloudagent-python that referenced this pull request Feb 10, 2021
krzosa pushed a commit to krzosa/aries-cloudagent-python that referenced this pull request May 5, 2021
Add linking to pds as an OYD extension. Add linking dris to service flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants