-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer for ACA-Py #2267
Add devcontainer for ACA-Py #2267
Conversation
Addressing an issue where it is difficult to get set up to debug and begin coding by adding a devcontainer. Signed-off-by: Jason Sherman <[email protected]>
So far so good, I was able to load the devcontainer in VSCode without any issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great! couple small comments
I started from scratch, didn't even have the dev container extension installed and can get things going with the instructions and container config here
Signed-off-by: Jason Sherman <[email protected]>
I would add a note of what you can't do with a dev container -- notably running the various Docker-based tools in the repo (e.g. Looks great and after the first build is pretty fast! |
Signed-off-by: Jason Sherman <[email protected]>
Something that might be worth trying. Evidently, docker-in-docker is possible with devcontainers, as per this: https://github.com/devcontainers/features/tree/main/src/docker-in-docker. It might be interesting to see if with that added to the devcontainer config if the ACA-Py demos can be run. |
Yes, I took a quick look at docker-in-docker, but didn't explore it fully (or try to implement it). I could spend more time on it if we want. |
How about for now, we just add a note about it in the readme, and an issue with a “help wanted” sign. |
I don't have anyone on my team actively using devcontainers right now but I think this would be a great addition. I agree with Stephen on getting this merged sooner than later and plan on making further enhancements in the future. |
Signed-off-by: Jason Sherman <[email protected]>
added docker-in-docker and updated the devcontainer readme to show how to run the demos within the container. |
For the devContainer, I'd recommend using |
Signed-off-by: Jason Sherman <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
Thanks for that... updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested out with running the demo and worked nicely. A couple of notes we can add, but overall looks good. Great work!
Addressing an issue where it is difficult to get set up to debug and begin coding by adding a devcontainer.
See Issue #2251 - this is only one small part of developer documentation. I wanted this out for feedback while we identify other areas of concern.