Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Maintainers list to be accurate and using the TOC format #2258

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Updating Maintainers list to be accurate and using the TOC format #2258

merged 6 commits into from
Jun 9, 2023

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Jun 8, 2023

Signed-off-by: Stephen Curran [email protected]

@swcurran swcurran requested a review from WadeBarnes June 8, 2023 17:16
@swcurran
Copy link
Contributor Author

swcurran commented Jun 8, 2023

@ryjones -- what do you think of this page format? The data in the first table (Roles) is all in the Settings tab, but regular contributors can't see that. Can they see the Hyperledger Teams pages that I linked into the page?

@ryjones
Copy link
Contributor

ryjones commented Jun 8, 2023

@swcurran I like it! @tkuhrt ?

@swcurran no, they can't see that page unless they're a member of the org, I think

@tkuhrt
Copy link

tkuhrt commented Jun 8, 2023

I like it, generally. The only thing that I would request change is the the contact information being filled in for the maintainers so that we can reach them if needed.

@swcurran
Copy link
Contributor Author

swcurran commented Jun 8, 2023

When Ry tagged you on this @tkuhrt , I knew you were going to say that :-). It's just a pain to track that down.

I'll get one...how about that? :-)

@tkuhrt
Copy link

tkuhrt commented Jun 9, 2023

I believe the original intent was to have at least one way of communicating with the maintainer if we needed to contact them, so at least one should be okay @swcurran

@swcurran swcurran requested a review from dbluhm June 9, 2023 18:25
MAINTAINERS.md Outdated
| TimoGlastra | Timo Glastra | Admin | | | [email protected] | Animo Solutions |
| WadeBarnes | Wade Barnes | Admin | | | [email protected] | BC Gov |

Daniel Bluhm <>, Daniel Hardman <[email protected]>, Andrew Whitehead <[email protected]>, Timo Glastra <[email protected]>, Shaanjot Gill <[email protected]>, Sam Curren <[email protected]>, Wade Barnes <[email protected]>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this line intentional?

Signed-off-by: Stephen Curran <[email protected]>
@swcurran
Copy link
Contributor Author

swcurran commented Jun 9, 2023

Sorry about that — no. Removed.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit 160b99d into openwallet-foundation:main Jun 9, 2023
@swcurran swcurran deleted the fix-maintainers-file branch July 4, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants