Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-tenant self-managed mediation verkey lookup #2232

Merged

Conversation

usingtechnology
Copy link
Contributor

fixes #2231

There are two ways to setup mediation for multitenancy. One is to have the base wallet mediate for all tenants, and the second is for each tenant to manage their own. In the second case, there was a bug when locating the verkey and packing the outbound message.

This PR checks if the base wallet is mediating and decides which responder to use. If the tenant is managing their own mediation then we need the sub-wallet profile to create the responder NOT the base wallet profile.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran
Copy link
Contributor

@TimoGlastra @dbluhm @ianco — could one of you review/approve this PR? Thanks!

@swcurran swcurran requested review from dbluhm, ianco and TimoGlastra May 12, 2023 20:06
Copy link
Contributor

@ianco ianco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@swcurran swcurran merged commit 76240b8 into openwallet-foundation:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Mediation, Multitenant Aca-Py - sub-wallet initiates mediation
3 participants