Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Upgrading ACA-Py document #2200

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Add Upgrading ACA-Py document #2200

merged 5 commits into from
Apr 5, 2023

Conversation

swcurran
Copy link
Contributor

@swcurran swcurran commented Apr 4, 2023

Signed-off-by: Stephen Curran [email protected]

Signed-off-by: Stephen Curran <[email protected]>
@swcurran swcurran requested a review from shaangill025 April 4, 2023 19:08

If the Maintainers of ACA-Py recognize a case where ACA-Py must be upgraded while
offline, a new Upgrade feature will be added that will prevent the "auto upgrade"
process from executing. See [Issue XXXX] for the status of that feature.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should #2201

If the Maintainers of ACA-Py recognize a case where ACA-Py must be upgraded while
offline, a new Upgrade feature will be added that will prevent the "auto upgrade"
process from executing. See [Issue XXXX] for the status of that feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also mention:
There are 2 flavours of this explicit upgrade mechanism, "critical" and "warning". With critical, it will stop the "auto upgrade" process, raise an exception and force users to do the upgrade offline first. With warning, it will stop the "auto upgrade" process, log a warning but allows ACA-Py to startup normally. In this case, the version is not updated in secure storage and it will only update when doing the upgrade offline.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've referenced the docs. We'll update this once when the merge of the #2204 is done -- perhaps as part of that PR, even.

### Forcing an upgrade

If you would like to force an upgrade from a given version, a pair of ACA-Py
configuration arguments can be used together. If you specify "`--from-version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mention an example for clarity:
For instance, if the version in secure storage has been set as v0.8.0 but for some reason you want to apply upgrades from >=v0.7.2, then you can specify "--from-version v0.7.2" and "--force-upgrade".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Confirming @shaangill025 that the "v" is needed in "--from-version". I've put it in, but is that right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, as we use "v" in config too.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit d863faa into openwallet-foundation:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants