Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Indy WalletAlreadyOpenedError during upgrade process #2196

Merged

Conversation

shaangill025
Copy link
Contributor

@shaangill025 shaangill025 commented Apr 3, 2023

Signed-off-by: Shaanjot Gill <[email protected]>
@swcurran
Copy link
Contributor

swcurran commented Apr 3, 2023

@Jsyro @usingtechnology — Didn’t want to put you on the critical path for this urgent PR by making you reviewers, but be aware of it and if you have any input, feel free.

Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
@shaangill025
Copy link
Contributor Author

Using PR #2189 docker-compose-agent.yml and docker-compose-wallet.yml in demo/docker-test directory, I tested the following scenarios:

  • New storage provisioned, no from_version in storage and startup args. It will default from_version to v0.7.5 and apply upgrade and set version to v0.8.1-rc0 [current version in version.py]
  • Startup with --from-version v0.7.2 and --force-upgrade, it disregards v0.8.1-rc0 from storage and applies upgrade with from_version as v0.7.2. This is the same thing @WadeBarnes will have to do, but with v0.7.5 specified.
  • Set version.py to v8.0.2, added config for v0.8.2 to YML file. On startup, version upgraded from v0.8.1-rc0 to v0.8.2
  • Also if there is no upgrade to apply, the version in storage is successfully updated.

@swcurran
Copy link
Contributor

swcurran commented Apr 3, 2023

Nice! Thanks.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit e89e3fd into openwallet-foundation:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants