fix: run only on main, forks ok

[anwalker293]

Addresses issue #2152 (https://indicio.atlassian.net/browse/ACAP-1004)

I did not include an environment variable, as GitHub seems to throw up its hands when you put it in the workflow file. There seems to be a workaround if you put the variable in .env, but I'm not sure if we want that though...

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[anwalker293]

Re: edit: fix: on schedule - Sorry, I put in for the flows to run on push of the main branch for testing purposes. Just removed this now, so this flow should only run nightly

[dbluhm]

A quick confidence check (and a third party review since Alex is on my team 🙂) on this would be appreciated before I hit merge @WadeBarnes @swcurran

[WadeBarnes]

I've typically used github.event.repository.full_name to get the repository name. I believe you also need to wrap the variable names in ${{ }}.

Examples:

• https://github.com/hyperledger/indy-node/blob/main/.github/workflows/build.yaml#L63
• https://github.com/bcgov/von-network/blob/main/.github/workflows/build-docker.yml#L16

[anwalker293]

@WadeBarnes I wanted to follow up with you regarding these changes. Thank you for your suggestion, it's greatly appreciated! It looks like this issue is more optional than strictly a problem (https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif). For the time being, I did keep the original format, but, if desired, I can change the format
However, I do greatly appreciate any advice, so please let me know if there's anything else you would like me to change!
Cheerio!

[WadeBarnes]

@anwalker293, Have you run any tests using this new workflow on your branch? For example tried to trigger it as is on your branch to make sure it behaves as expected and then changed the github.repository to match yours to ensure it triggers as expected? Also have you tested the workflow dispatch trigger?

We can see from here, https://github.com/hyperledger/aries-cloudagent-python/actions/runs/4630877399, it's running, but is it behaving as intended on another repo?

[anwalker293]

@WadeBarnes I believe so! :) I tested it on my fork of this repo, on the branch test (https://github.com/anwalker293/aries-cloudagent-python/actions/runs/4691869092)

[WadeBarnes]

@WadeBarnes I believe so! :) I tested it on my fork of this repo, on the branch test (https://github.com/anwalker293/aries-cloudagent-python/actions/runs/4691869092)

That's a different workflow, it's the codeql.yml workflow. You're PR is for the nightly-tests.yml workflow. I don't see any runs associated to it in your repo.

[anwalker293]

@WadeBarnes Fixed! (+ the manual triggering for forks can be found here: https://github.com/anwalker293/aries-cloudagent-python/actions/runs/4788375998)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information