feat: allow marking non-SOV DIDs as public #2144
Conversation
Remove the restriction for did:sov when marking a DID as public **at the wallet level**. Signed-off-by: Clément Humbert <[email protected]>
|
@chumbert — can you please update the branch so we can merge it? Thanks! |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Can someone with the permissions restart the integration tests ? It looks like the failing test is flaky and not related to these changes. |
|
@ryjones — is there a GitHub role/team that enables a “rerun pipeline” action? If so, could you add me to that group? |
|
@swcurran if you go here, do you see the failed tests? If you go here, for example, do you see the "rerun jobs" button at the top? |
|
Thanks @ryjones — I was able to find that button. Cool stuff - didn’t know it was possible. That will be a big a help. Of course if we made the tests a little more stable, this wouldn’t happen… :-) |
In the continuity of the work with non-indy DIDs: remove the restriction for did:sov when marking a DID as public at the wallet level.
These wallet implementations don't include any indy-related logic. All the logic and restrictions are done in the
wallet/set-public-didroute.This change allows using the wallet to mark DIDs from other methods as being public as opposed to having to re-implement all the logic in an ad-hoc plugin.