Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add verification method issue-credentials-2.0/send endpoint #2135

Conversation

chumbert
Copy link
Contributor

Accommodate credential sending for did methods that are not did:sov or did:key by adding an optional verification_method parameter to the send endpoint options.

Currently, verification method is derived "automatically" for did:sov and did:key, raising error for any other DID method.

The parameter is optional and stored along the credential exchange for recall when issuing the credential.

… endpoint

Accomodate credential sending for did methods that are not did:sov or
did:key by adding an optional `verification_method` parameter to the send endpoint options.

Signed-off-by: Clément Humbert <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dbluhm
Copy link
Contributor

dbluhm commented Feb 24, 2023

I think this is an important PR as we increase support for other DID methods but I think some more eyes on this change would be good. @ianco @swcurran

@dbluhm dbluhm merged commit 179ef19 into openwallet-foundation:main Feb 24, 2023
@dkulic dkulic deleted the feature/provide-verification-method-send-endpoint branch March 14, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants