Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: universal resolver - configurable authentication #2095

Conversation

chumbert
Copy link
Contributor

Context: we want to allow aca-py instances to connect to privately run universal resolvers such as the one from godiddy. This requires authentication.

  • Add --universal-resolver-bearer-token to allow authentication against privately run universal resolvers.

BREAKING CHANGE:
Configured url should now include the /1.0 suffix. The default url reflects that changes.

  • This is to have a more flexible configuration of the universal resolver's api route (required in the case of godiddy).
  • The alternative would be to make the suffix configurable too. I just found it a bit fiddly both in code and configuration. Let me know if the breaking change in configuration is not acceptable.

Signed-off-by: Clément Humbert [email protected]

* Add `--universal-resolver-bearer-token` to allow authentication
  against privately run universal resolvers

BREAKING CHANGE:
* Configured url should now include the `/1.0` suffix. The default url
  reflects that changes

Signed-off-by: Clément Humbert <[email protected]>
@dbluhm
Copy link
Contributor

dbluhm commented Jan 26, 2023

Requesting a sanity check before I hit merge 🙂 @ianco

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@swcurran swcurran merged commit e4ab945 into openwallet-foundation:main Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants