Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin api richer hints #208

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Admin api richer hints #208

merged 3 commits into from
Oct 8, 2019

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Oct 8, 2019

Richer form hints for requests and results in admin API swagger UI. Tighter marshmallow validation where obvious.

andrewwhitehead
andrewwhitehead previously approved these changes Oct 8, 2019
Copy link
Contributor

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comprehensive!

@sklump
Copy link
Contributor Author

sklump commented Oct 8, 2019

Sorry Andrew, I see some problems still. I will touch it up and commit within the hour.

@codecov-io
Copy link

Codecov Report

Merging #208 into master will increase coverage by 0.2%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #208     +/-   ##
=========================================
+ Coverage   72.46%   72.66%   +0.2%     
=========================================
  Files         219      219             
  Lines       10055    10131     +76     
=========================================
+ Hits         7286     7362     +76     
  Misses       2769     2769

@andrewwhitehead andrewwhitehead merged commit 8290aed into openwallet-foundation:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants