Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix message dispatch; clean up LGTM warnings #203

Merged
merged 7 commits into from
Sep 27, 2019
Merged

Fix message dispatch; clean up LGTM warnings #203

merged 7 commits into from
Sep 27, 2019

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@5db1d89). Click here to learn what that means.
The diff coverage is 33.33%.

@@            Coverage Diff            @@
##             master     #203   +/-   ##
=========================================
  Coverage          ?   72.24%           
=========================================
  Files             ?      218           
  Lines             ?     9986           
  Branches          ?        0           
=========================================
  Hits              ?     7214           
  Misses            ?     2772           
  Partials          ?        0

@lgtm-com
Copy link

lgtm-com bot commented Sep 27, 2019

This pull request fixes 7 alerts when merging 012d11a into 5db1d89 - view on LGTM.com

fixed alerts:

  • 3 for Unused local variable
  • 3 for Variable defined multiple times
  • 1 for Loop variable capture

swcurran
swcurran approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brief review, but not able to run code. Will merge and we can address.

@swcurran swcurran merged commit 5ca8754 into openwallet-foundation:master Sep 27, 2019
@andrewwhitehead andrewwhitehead deleted the issue-rollup branch February 29, 2020 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewwhitehead @codecov-io @swcurran