Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/txn job setting #1994

Merged
merged 2 commits into from
Oct 27, 2022
Merged

Fix/txn job setting #1994

merged 2 commits into from
Oct 27, 2022

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Oct 27, 2022

Fixes a timing issue where the endorser and author are connecting and trying to set connection met-data before the connection is "active".

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

swcurran
swcurran approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- removing code, nice!

@ianco ianco merged commit 42c2df9 into openwallet-foundation:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianco @swcurran