Fix: OOB - Handling of minor versions

[shaangill025]

Signed-off-by: Shaanjot Gill [email protected]

• resolve OOB Handling of both 1.0 and 1.1 messages #1917
• Fixes the following error:

File "/home/indy/.venv/lib/python3.6/site-packages/aries_cloudagent/utils/classloader.py", line 97, in load_class
   |     if "." in class_name:
   | TypeError: argument of type 'NoneType' is not iterable

• Working on adding minor changes for adding OOB 1.1 and a mechanism for ACA-Py to respond with the same supported version, basically, handshake-reuse-accepted 1.1 for handshake-reuse 1.1 and handshake-reuse-accepted 1.0 for handshake-reuse 1.0.

[swcurran]

Needs to support OOB 1.0 and 1.1.

[shaangill025]

@swcurran As discussed, the problem reports [version-with-degraded-features, fields-ignored-due-to-version-mismatch] as specified in RFC0003 have been implemented but commented out.

[swcurran]

@dbluhm FYI.

For all. I suggested that to get this out faster we NOT send the "warning" problem reports -- e.g. responding with higher version of responding with lower version. Are we good with that, or since they are already done and commented out, should we support them. I'm a bit nervous of mobile agents getting problem reports they don't expect and splatting an error on the screen.

[ianco]

I suggested that to get this out faster we NOT send the "warning" problem reports

I agree ... if this is going in a patch release we should minimize the change we are introducing. The full functionality can go into the next 1.0.0-rcx release

[swcurran]

@WadeBarnes -- looks like the SonarCloud config is processing test code again. Could you please take a look at that?

Do we need to be concerned about the 4 relevant code smells? The complexity of the version checking code (I assume that is just the way it is) and the raising of the exceptions. All good with those?

The unused variables in the test code and the commented out code are fine/intended, I'm sure.

Thanks

[andrewwhitehead]

Wouldn't this overwrite message_type for all the class instances going forward?

[shaangill025]

To update message_type in Meta, I found this can only be done in the classmethod before initialization. Regarding overwriting, $version is only present in message_types for OOB v1_0, so it will overwrite. But when we have a hardcoded version such as in other protocols then it won't overwrite.

[swcurran]

@WadeBarnes --- is there a way other than pushing another commit to trigger a re-execution of Circle/CI when things like this happen? I hadn't heard about the Circle/CI issues -- any update on that? Should we take the plunge here and switch to another tool?

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
9 Code Smells

No Coverage information
3.0% Duplication