chore: update pydid #1915
Merged
chore: update pydid #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent changes to the resolution of sov/indy DIDs caused PyDID to parse service endpoints that should have been recognized as DIDComm services as plain services. This broke some logic in accepting invitations from public DIDs. Pulling in these updates from PyDID resolves the issue. Signed-off-by: Daniel Bluhm <[email protected]>
|
The error this fixes: Caused by these lines: |
andrewwhitehead
approved these changes
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## main #1915 +/- ##
=======================================
Coverage 93.68% 93.68%
=======================================
Files 540 540
Lines 34187 34187
=======================================
Hits 32027 32027
Misses 2160 2160 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent changes to the resolution of sov/indy DIDs caused PyDID to parse
service endpoints that should have been recognized as DIDComm services
as plain services. This broke some logic in accepting invitations from
public DIDs. Pulling in these updates from PyDID resolves the issue.
Signed-off-by: Daniel Bluhm [email protected]