Remove aca-py check for unrevealed revealed attrs on proof validation #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1913 +/- ##
==========================================
- Coverage 93.68% 93.66% -0.02%
==========================================
Files 539 539
Lines 34162 34206 +44
==========================================
+ Hits 32003 32040 +37
- Misses 2159 2166 +7 |
Signed-off-by: Ian Costanzo <[email protected]>
Signed-off-by: Ian Costanzo <[email protected]>
andrewwhitehead
approved these changes
Aug 26, 2022
|
FYI I ran the integration tests locally and everything passed, I think the error is just due to random "solar flares" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ian Costanzo [email protected]
Addresses issue #1893
Removes the "hard" verification on un-revealed attributes and adds "verify_msgs" to the presentation exchange record to describe any warnings or errors encountered when processing the received proof.