Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect response schema for discover features #1912

Conversation

dbluhm
Copy link
Contributor

@dbluhm dbluhm commented Aug 23, 2022

Small change that won't really affect anything but OpenAPI json and client generators.

The query features endpoint returns the discovery record directly rather than nesting it in a results attribute.

@dbluhm dbluhm force-pushed the fix/query-features-response-schema branch from 1e55e53 to 859d5f5 Compare August 23, 2022 19:14
@codecov-commenter
Copy link

Codecov Report

Merging #1912 (1e55e53) into main (60fb699) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1e55e53 differs from pull request most recent head 859d5f5. Consider uploading reports for the commit 859d5f5 to get more accurate results

@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
- Coverage   93.67%   93.67%   -0.01%     
==========================================
  Files         539      539              
  Lines       34145    34143       -2     
==========================================
- Hits        31984    31982       -2     
  Misses       2161     2161              

@andrewwhitehead andrewwhitehead merged commit cbd5cee into openwallet-foundation:main Aug 26, 2022
@dbluhm dbluhm deleted the fix/query-features-response-schema branch September 17, 2022 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants