fix: schema class can set Meta.unknown #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <[email protected]>
Signed-off-by: Daniel Bluhm <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
- Coverage 93.55% 93.53% -0.02%
==========================================
Files 539 539
Lines 34526 34559 +33
==========================================
+ Hits 32300 32326 +26
- Misses 2226 2233 +7 |
|
SonarCloud Quality Gate failed.
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
ianco
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the Schema class of a model to determine the default
unknownbehavior. Without this, if you have a schema where you expect extra values to be present, every timedeserializeorserializeis called, you must setunknown=INCLUDE. Now, in theMetaclass of the Schema,unknowncan be set to some value that will be respected as the default if not overrided by method parameter.While I was at it, I also touched up some of the typing. I'm not fond of using
@overloadbut I think it's the best way to address typing a method where a bool flag impacts the return type.