Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set prefix for integration test demo agents; some code cleanup #1840

Merged

Conversation

andrewwhitehead
Copy link
Contributor

Setting the prefix makes the test output much clearer:

Acme.agent | Received transaction message: transaction_endorsed
INFO:aiohttp.access:172.17.0.1 [23/Jun/2022:13:48:00 +0000] "POST /webhooks/topic/endorse_transaction/ HTTP/1.1" 200 149 "-" "Python/3.6 aiohttp/3.8.1"
Bob.agent | Received transaction message: transaction_endorsed

compared to:

Aries | Received transaction message: transaction_endorsed
INFO:aiohttp.access:172.17.0.1 [23/Jun/2022:13:48:00 +0000] "POST /webhooks/topic/endorse_transaction/ HTTP/1.1" 200 149 "-" "Python/3.6 aiohttp/3.8.1"
Aries | Received transaction message: transaction_endorsed

@andrewwhitehead andrewwhitehead requested a review from ianco June 23, 2022 19:51
@codecov-commenter
Copy link

Codecov Report

Merging #1840 (f149e9e) into main (544ec3a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1840   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files         536      536           
  Lines       34012    34012           
=======================================
  Hits        31878    31878           
  Misses       2134     2134           

@swcurran swcurran added the 0.7.4 label Jun 24, 2022
@swcurran
Copy link
Contributor

@dbluhm @frostyfrog @TimoGlastra @DaevMithran -- could one of you please do a review of this PR? Thanks!

@swcurran swcurran merged commit 3c250c7 into openwallet-foundation:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants