Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Present Proof v2 - check_proof_vs_proposal update to support proof request with restrictions #1820

Merged
merged 6 commits into from
Jun 21, 2022
Merged

Fix: Present Proof v2 - check_proof_vs_proposal update to support proof request with restrictions #1820

merged 6 commits into from
Jun 21, 2022

Conversation

shaangill025
Copy link
Contributor

@shaangill025 shaangill025 requested a review from TimoGlastra June 17, 2022 14:13
TimoGlastra
TimoGlastra previously approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add a test case to prevent this from unintentionally being introduced again in the future?

@shaangill025
Copy link
Contributor Author

Implemented unit tests for revealed attrs and predicate bounds. For revealed attr groups, restrictions cannot be empty and a V20PresRequest marshmallow ValidationError gets triggered:

Attribute specification on 'names' must have non-empty restrictions

@swcurran swcurran merged commit cdea418 into openwallet-foundation:main Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcurran swcurran swcurran approved these changes

@TimoGlastra TimoGlastra TimoGlastra left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

present proof v2 does not support proof request without restrictions
3 participants
@shaangill025 @swcurran @TimoGlastra