Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix put_file when the server returns a redirect #1808

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

andrewwhitehead
Copy link
Contributor

I believe this fix only applies to tails file uploads at the moment. Previously, aiohttp would encounter an error because it closed the tails file after the first attempt.

@swcurran
Copy link
Contributor

I assume this addresses #1807 ? @frostyfrog , can you please take a look?

Looks like some tests are failing.

@andrewwhitehead
Copy link
Contributor Author

@swcurran No, it doesn't fix that issue.

@TheTechmage
Copy link
Contributor

It looks like this change would merely throw an explicit exception when it cannot open the tails file instead of the one I'm seeing.

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #1808 (d5ac9dd) into main (592dfd0) will decrease coverage by 0.03%.
The diff coverage is 54.54%.

@@            Coverage Diff             @@
##             main    #1808      +/-   ##
==========================================
- Coverage   93.74%   93.70%   -0.04%     
==========================================
  Files         534      534              
  Lines       33846    33871      +25     
==========================================
+ Hits        31728    31738      +10     
- Misses       2118     2133      +15     

@swcurran swcurran merged commit c308329 into openwallet-foundation:main Jun 15, 2022
@andrewwhitehead andrewwhitehead deleted the fix/put-redirect branch July 7, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants