Feature/undelivered events #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
Signed-off-by: Micah Peltier <[email protected]>
mepeltier
force-pushed
the
feature/undelivered-events
branch
from
4868141 to
c80ed59
Compare
dbluhm
approved these changes
Mar 29, 2022
|
I was involved in this PR behind the scenes so probably a good idea to get a review from another ACA-Py commiter 🙂 |
|
@mepeltier can you sync your PR with the latest |
ianco
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a number of events which are emitted when a message is undelivered.
These events can be leveraged by plugins to take certain actions when messages are undelivered, such as writing the message to a persistent queue, sending a push notification to a mobile device that attempted to send the message, or some other action.
The events leverage the existing
OutboundSendStatusstates and don’t supersede the current return value. TheOutboundSendStatusis still returned within ACA-Py as it has been, so this shouldn’t impact any existing functionality, but I’d be happy to hear any concerns I’ve not thought of. Thanks to @dbluhm for his feedback prior to this PR being opened.