Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move database operations inside the session context #1633

Conversation

acuderman
Copy link
Contributor

What is this PR for?

  • Error state saving was done when the session could be already disposed

Signed-off-by: Andraž Cuderman [email protected]

@codecov-commenter
Copy link

Codecov Report

Merging #1633 (0da83a1) into main (d00050f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1633   +/-   ##
=======================================
  Coverage   95.67%   95.67%           
=======================================
  Files         528      528           
  Lines       32643    32643           
=======================================
  Hits        31230    31230           
  Misses       1413     1413           

@acuderman
Copy link
Contributor Author

@andrewwhitehead @swcurran Can someone please take a look? Thanks

@andrewwhitehead andrewwhitehead merged commit ee88fa7 into openwallet-foundation:main Feb 23, 2022
@ctomc ctomc deleted the feat-IDENT-4193-problem-report-deadlock branch August 18, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants