fix: use invitation key for connection query #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimoGlastra
force-pushed
the
fix/connection-invitation-key
branch
from
491d8dc to
1ad536f
Compare
Signed-off-by: Timo Glastra <[email protected]>
TimoGlastra
force-pushed
the
fix/connection-invitation-key
branch
from
1ad536f to
aee9c21
Compare
Signed-off-by: Timo Glastra <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
=======================================
Coverage 95.76% 95.76%
=======================================
Files 527 527
Lines 32312 32312
=======================================
Hits 30942 30942
Misses 1370 1370 |
shaangill025
approved these changes
Dec 21, 2021
| @@ -1,5 +1,6 @@ | |||
| import json | |||
|
|
|||
| from unittest.mock import ANY | |||
There was a problem hiding this comment.
Neat, I learned a new trick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Timo Glastra [email protected]
Invitation key was not taken into account for get connections endpoint.
If possible, would like to get this in the upcoming 0.7.3 release :)