Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added logging documentation #1519

Merged
merged 2 commits into from
Nov 29, 2021
Merged

Conversation

chriamue
Copy link
Contributor

@chriamue chriamue commented Nov 25, 2021

Added markdown documentation of logging in Acapy.

  • Command Line Arguments
  • Environment Variables
  • Acapy Config
  • Logging Config File
  • Link in dev readme

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2021

Codecov Report

Merging #1519 (b35e364) into main (2960c51) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1519   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files         509      509           
  Lines       30985    30985           
=======================================
  Hits        29683    29683           
  Misses       1302     1302           

@chriamue
Copy link
Contributor Author

Whats the best location for Logging.md file?

@swcurran
Copy link
Contributor

I think the root is probably fine for now, as others are there. We should probably put them into docs, but I think we need to do them all together.

The question is where we want to put the link to this file. I think it should go into the DevReadme.md file at some useful point.

@ianco -- please take a read through this for accuracy and to approve.

Thanks for the contribution -- good stuff.

@ianco
Copy link
Contributor

ianco commented Nov 25, 2021

The question is where we want to put the link to this file. I think it should go into the DevReadme.md file at some useful point.

Yes looks good thanks for the PR. I suggest to link from docs/logging/docs/GettingStartedAriesDev somewhere?

@swcurran
Copy link
Contributor

I would think that this section of the Developer's ReadMe would be best -- https://github.com/hyperledger/aries-cloudagent-python/blob/main/DevReadMe.md#developing

@chriamue chriamue marked this pull request as ready for review November 29, 2021 09:01
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Thanks!

@swcurran swcurran merged commit 0381628 into openwallet-foundation:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants