Discover Features Protocol: v1_0 refactoring and v2_0 implementation #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into discover-feature-v2
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
…t-python into discover-feature-v2
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
Signed-off-by: Shaanjot Gill <[email protected]>
ianco
approved these changes
Nov 23, 2021
|
|
||
| def determine_goal_codes(self) -> Sequence[str]: | ||
| """Return defined goal_codes.""" | ||
| return [] |
There was a problem hiding this comment.
Should this return goal_codes_matching_query()?
There was a problem hiding this comment.
In the context of GoalCodeRepository, I am using controller to play a similar role to message_types (with ProtocolsRegistry), determine_goal_code is returning the specified goal-codes for that protocol to build up the registry and then goal_codes_matching_query is called upon in there. I don't think we should be returning goal_codes_matching_query inside determine_goal_codes.
May be, I can rename determine_goal_codes to return_goal_codes to avoid any confusion?
There was a problem hiding this comment.
@shaangill025 it's fine you don't need to change it, PR is approved :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier implementation involved calling
/featuesendpoint [underservertag] to disclose protocols for that agent. It did not involve the flow ofAriesmessages as specified in the RFC.Major Changes
--auto-disclose-featuresEnables proactive disclosure for v2.0. Such agent will automatically disclose features to another agent when an active connection gets established.--disclose-features-listcan be used to limit what to disclose and if not specified, then all are disclosed.--disclose-features-listProvides control over what features to publish. Accepts a path to YAML config file [example structure below]. This is valid for both v1.0 and v2.0/features under serverendpointdiscover-featurestagdiscover-features v2.0tagYAML config file structure, such agent will only disclose
did:sov:BzCbsNYhMrjHiqZDTUASHg;spec/action-menu/1.0protocol and/oraries.vcgoal-codeTesting
/discover-features/query. If noconnection_idis specified then it processes the query on the same agent (disclose features of the same agent). This essentially mimics what can be achieved using/features[underserver]. To look up either all records or a record byconnection_id, use/discover-features/records./discover-features-2.0/queries. Same logic when noconnection_idis specified as above. To look up either all records or a record byconnection_id, use/discover-features-2.0/records.connection_idis an unique identifier for these records.