Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TypeError #1494

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix TypeError #1494

merged 1 commit into from
Nov 16, 2021

Conversation

gorgsenegger
Copy link
Contributor

When calling /schemas/{schema_id}/write_record, a server error 500 occurrs. The log output says

TypeError: inject() got an unexpected keyword argument 'required'

Other code in this file seems to indicate that the proposed change is what is needed to prevent the error from being thrown.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2021

Codecov Report

Merging #1494 (5a571b1) into main (4b06af1) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1494   +/-   ##
=======================================
  Coverage   95.70%   95.70%           
=======================================
  Files         489      489           
  Lines       30264    30264           
=======================================
  Hits        28965    28965           
  Misses       1299     1299           

@ianco
Copy link
Contributor

ianco commented Nov 16, 2021

Hi @gorgsenegger thanks for the PR! Note that all commits to hyperledger repo's must be DCO signed (--signoff or -s)

See: https://github.com/hyperledger/aries-cloudagent-python/pull/1494/checks?check_run_id=4224754831

When calling /schemas/{schema_id}/write_record, a server error 500 occurrs. The log output says

    TypeError: inject() got an unexpected keyword argument 'required'

Signed-off-by: Gorgsenegger <[email protected]>
@gorgsenegger
Copy link
Contributor Author

Hi @ianco, I'm new to this, did the signoff work? Thank you!

@ianco
Copy link
Contributor

ianco commented Nov 16, 2021

Yep it worked, thanks!

@swcurran
Copy link
Contributor

Yup - DCO looks good.

This seems like a Big Deal. Does this mean we are going to need an immediate 0.7.3 release?

@ianco
Copy link
Contributor

ianco commented Nov 16, 2021

This seems like a Big Deal. Does this mean we are going to need an immediate 0.7.3 release?

The error is in the schemas_fix_schema_wallet_record() method, which is not a critical method (imho)

@ianco ianco merged commit 3734240 into openwallet-foundation:main Nov 16, 2021
@shaangill025
Copy link
Contributor

Same change might be needed here, https://github.com/hyperledger/aries-cloudagent-python/blob/f9506df755e46c5be93b228c8811276b743a1adc/aries_cloudagent/messaging/credential_definitions/routes.py#L391.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants