Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Startup and shutdown events (prep for endorser updates) #1459

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Oct 27, 2021

Signed-off-by: Ian Costanzo [email protected]

Added startup and shutdown event notifications

@TimoGlastra this adds startup/shutdown notifications (as discussed on RocketChat I think?), let me know if this is what you were thinking. This is for the base wallet but assume we need something similar for sub-wallets?

@ianco ianco requested a review from TimoGlastra October 27, 2021 22:39
@TimoGlastra TimoGlastra linked an issue Oct 28, 2021 that may be closed by this pull request
TimoGlastra
TimoGlastra previously approved these changes Oct 28, 2021
Copy link
Contributor

@TimoGlastra TimoGlastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @ianco. Thanks for looking at this.

And also a lot simpler than I thought

aries_cloudagent/core/util.py Outdated Show resolved Hide resolved
@dbluhm
Copy link
Contributor

dbluhm commented Oct 28, 2021

I think this allows us to move several things out of the conductor startup (I'm thinking especially of mediator connection setup). We're working on some stuff related to queuing that would also benefit from this. Any chance we can go ahead and review the addition of these events and not wait until the author/endorser pieces are added? 🙂

@ianco ianco marked this pull request as ready for review October 28, 2021 15:07
@ianco ianco changed the title Auto setup author/endorser connection if possible Startup and shutdown events (prep for endorser updates) Oct 28, 2021
Signed-off-by: Ian Costanzo <[email protected]>
@ianco
Copy link
Contributor Author

ianco commented Oct 28, 2021

I think this allows us to move several things out of the conductor startup (I'm thinking especially of mediator connection setup). We're working on some stuff related to queuing that would also benefit from this. Any chance we can go ahead and review the addition of these events and not wait until the author/endorser pieces are added? 🙂

For sure let's merge this and then I can do the rest of the work on a separate PR

@ianco ianco requested a review from dbluhm October 28, 2021 15:25
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ianco ianco closed this Oct 28, 2021
@ianco ianco reopened this Oct 28, 2021
@ianco ianco merged commit 3165990 into openwallet-foundation:main Oct 28, 2021
@karimStekelenburg
Copy link
Contributor

This is amazing! Nice job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Access profile on plugin initialization
4 participants