-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Startup and shutdown events (prep for endorser updates) #1459
Startup and shutdown events (prep for endorser updates) #1459
Conversation
Signed-off-by: Ian Costanzo <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @ianco. Thanks for looking at this.
And also a lot simpler than I thought
I think this allows us to move several things out of the conductor startup (I'm thinking especially of mediator connection setup). We're working on some stuff related to queuing that would also benefit from this. Any chance we can go ahead and review the addition of these events and not wait until the author/endorser pieces are added? 🙂 |
Signed-off-by: Ian Costanzo <[email protected]>
For sure let's merge this and then I can do the rest of the work on a separate PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is amazing! Nice job! |
Signed-off-by: Ian Costanzo [email protected]
Added startup and shutdown event notifications
@TimoGlastra this adds startup/shutdown notifications (as discussed on RocketChat I think?), let me know if this is what you were thinking. This is for the base wallet but assume we need something similar for sub-wallets?