Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyNaCl instead of pysodium; update dependencies #143

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

andrewwhitehead
Copy link
Contributor

@andrewwhitehead andrewwhitehead commented Aug 14, 2019

PyNaCl publishes wheel packages with libsodium included, which helps to simplify installation.

Note: recent versions of marshmallow pass additional arguments to pre-load and post-load hooks.

@codecov-io
Copy link

Codecov Report

Merging #143 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #143      +/-   ##
==========================================
+ Coverage   73.46%   73.47%   +<.01%     
==========================================
  Files         188      188              
  Lines        8220     8222       +2     
==========================================
+ Hits         6039     6041       +2     
  Misses       2181     2181

Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks consistent. Ran demos.

@swcurran swcurran merged commit 3081f10 into openwallet-foundation:master Aug 14, 2019
@andrewwhitehead andrewwhitehead deleted the pynacl-support branch February 29, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants