Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode DIDComm messages before sent to the queue #1408

Merged
merged 6 commits into from
Sep 10, 2021
Merged

Encode DIDComm messages before sent to the queue #1408

merged 6 commits into from
Sep 10, 2021

Conversation

acuderman
Copy link
Contributor

What is this PR for?

This PR fixes issue #1402

@acuderman acuderman force-pushed the feat-IDENT-3334-external-queue-encode branch from 5a5a833 to 39ddfc7 Compare September 10, 2021 12:31
@acuderman
fix(IDENT-3334): Add blank line
58df851 
Signed-off-by: Andraž Cuderman <[email protected]>
@acuderman
Revert "fix(IDENT-3334): Add blank line"
514301d 
This reverts commit a67df43.

Signed-off-by: Andraž Cuderman <[email protected]>
@acuderman acuderman force-pushed the feat-IDENT-3334-external-queue-encode branch from 0dd3638 to 514301d Compare September 10, 2021 13:21
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2021 •
edited
Loading

Codecov Report

Merging #1408 (0dd3638) into main (31580f8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 0dd3638 differs from pull request most recent head 514301d. Consider uploading reports for the commit 514301d to get more accurate results

@@           Coverage Diff           @@
##             main    #1408   +/-   ##
=======================================
  Coverage   95.31%   95.32%           
=======================================
  Files         482      482           
  Lines       29121    29128    +7     
=======================================
+ Hits        27758    27765    +7     
  Misses       1363     1363

dbluhm
dbluhm approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working with one of our queue implementations we're working on. Thanks for fixing this one.

andrewwhitehead
andrewwhitehead approved these changes Sep 10, 2021
View reviewed changes
Copy link
Contributor

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally that this doesn't seem to have any significant effects on performance

@andrewwhitehead andrewwhitehead merged commit b0009e1 into openwallet-foundation:main Sep 10, 2021
@dbluhm dbluhm mentioned this pull request Sep 10, 2021
Closed
@ctomc ctomc deleted the feat-IDENT-3334-external-queue-encode branch July 14, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbluhm dbluhm dbluhm approved these changes

@andrewwhitehead andrewwhitehead andrewwhitehead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@acuderman @codecov-commenter @andrewwhitehead @dbluhm