Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible timeout support in detect_process #125

Merged

Conversation

andrewwhitehead
Copy link
Contributor

Fixes an issue with the demo Faber agent freezing while waiting for the swagger JSON to be downloaded

@andrewwhitehead andrewwhitehead requested a review from nrempel August 6, 2019 20:46
@codecov-io
Copy link

codecov-io commented Aug 6, 2019

Codecov Report

Merging #125 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #125   +/-   ##
=======================================
  Coverage   73.24%   73.24%           
=======================================
  Files         184      184           
  Lines        7940     7940           
=======================================
  Hits         5816     5816           
  Misses       2124     2124

…a single request for the swagger JSON

Signed-off-by: Andrew Whitehead <[email protected]>
Copy link
Contributor

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. Looks good.

@swcurran swcurran merged commit 33321aa into openwallet-foundation:master Aug 7, 2019
@andrewwhitehead andrewwhitehead deleted the fix-detect-process branch February 29, 2020 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants