Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA workflow for aca-py integration tests #1046

Merged
merged 7 commits into from
Apr 14, 2021

Conversation

ianco
Copy link
Contributor

@ianco ianco commented Mar 22, 2021

Workflow can run on PR (hyperledger repo) or manually. Runs a specific sub-set of bdd tests since some tests cause test execution to "hang" under GHA:

./run_bdd - runs all the tests, can be run manually
./run_bdd -t @GHA - runs a sub-set of tests - should be sufficient to smoke test existing functionality

Workflow is setup to run its own indy ledger and tails server, but can be run with external ledger/tails server using environment settings.

"Actions" are re-factored the same way as they are setup under AATH.

ianco added 2 commits March 22, 2021 06:41
Signed-off-by: Ian Costanzo <[email protected]>
@codecov-io
Copy link

codecov-io commented Apr 1, 2021

Codecov Report

Merging #1046 (925016b) into main (87165c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1046   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         380      380           
  Lines       21804    21804           
=======================================
  Hits        21667    21667           
  Misses        137      137           

@ianco ianco marked this pull request as ready for review April 6, 2021 20:22
@andrewwhitehead
Copy link
Contributor

Looks good, I think we may want to merge some open PRs first before rebasing this, in case the new tests trip them up

@ianco
Copy link
Contributor Author

ianco commented Apr 12, 2021

Looks good, I think we may want to merge some open PRs first before rebasing this, in case the new tests trip them up

There isn't any reason to wait to merge this PR. If the GHA fails it won't (yet) block any of the PR's, and it would be good to get this merged so if the GHA does fail then it will be visible.

@andrewwhitehead andrewwhitehead merged commit 32d7e40 into openwallet-foundation:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants