Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credential record state not updated after revocation #1539

Closed
DaevMithran opened this issue Dec 8, 2021 · 3 comments
Closed

Credential record state not updated after revocation #1539

DaevMithran opened this issue Dec 8, 2021 · 3 comments

Comments

@DaevMithran
Copy link
Contributor

There should be a credential_revoked state for credential records, currently we have to use a seperate api to know the revocation status and the state of credential records remain in credential_issued even after revocation. The update should also reflect in the credential records.

@swcurran
Copy link
Contributor

swcurran commented Dec 8, 2021

Agreed. Could you do a PR for this?

That said -- our general philosophy is credential status be kept by the controller with the business logic, and not remain in the ACA-Py secure storage beyond the execution of the issuance protocol. That means both that the secure storage DB size is minimized and reduces security concerns about PII storage as it will only be in one place long term (the business system) and not replicated in the agent secure storage.

@DaevMithran
Copy link
Contributor Author

Agreed. That's a valid point. As we are supporting revocation in two ways either using cred_ex_id or rev_reg_id. The first approach will work only if the credential record is in the ACA-Py secure storage, So we can change the state of credential record to credential_revoked only when the credential record is in the ACA-Py secure storage.
I'll create a PR for this. Thank you for the response.

@swcurran
Copy link
Contributor

Addressed by #1545

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants